Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using
allow_redirects=False
, we have interfaces forresponse.next()
andresponse.anext()
,which can be used to issue the next redirect request.
The intent of these is to mirror the interface from
requests
, which also has aresponse.next
.However It turns out that I've made an error in what I thought the interface we were mirroring does. When using
requests
withallow_redirects=False
, theresponse.next
isn't a callable. It's an optional request instance, that can be used withclient.send(...)
to send the next response.Since one of our desired aims is for full parity with requests, we ought to be covering that API, and not the callable
.next
interface that we're currently exposing.This pull request adds
response.next_request
as a more clearly named version of the requests API.In the next version bump I think we should follow up on this PR by removing
response.next()
andresponse.anext()
as unnecessary bits of API.