Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test_auth.py to use MockTransport class. #1288

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Refactor test_auth.py to use MockTransport class. #1288

merged 2 commits into from
Sep 14, 2020

Conversation

tomchristie
Copy link
Member

Follow up to #1281 - refactors test_auth.py to use the nice MockTransport class.

Possible later follow ups here...

  • We should switch over to a plain import httpx. (test_auth.py uses from httpx import ... for a bunch of stuff, where we're mostly now sticking with a style of import httpx in other test cases.)
  • There's a bunch of test cases that are currently async, but could probably be plain sync cases, which we should prefer where possible.

@tomchristie tomchristie added the refactor Issues and PRs related to code refactoring label Sep 14, 2020
florimondmanca
florimondmanca approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@tomchristie tomchristie merged commit 2d6c30d into master Sep 14, 2020
@tomchristie tomchristie deleted the refactor-test-auth branch September 14, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
refactor Issues and PRs related to code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomchristie @florimondmanca