Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consideration, since this is not strictly required and potentially breaking for users that incorrectly relied on
Auth()
representing "no auth" instead of the base auth class interface, but a potentially nice clarification thatAuth
should only be treated as an abstract interface that can't be used as-is.This PR drops the default "do nothing" implementation in
Auth
, and moves it to a utilityNoAuth
class.Prompted since @tomchristie interestingly showed the async-capable
Auth
class using an abstract.auth_flow()
method (raisesNotImplementError
) in #1217 (comment).