Raise TypeError on invalid query params. (#2523)

* Raise TypeError on invalid query params * Fix TypeError * Update tests/models/test_queryparams.py Co-authored-by: Michael Adkins <[email protected]> * Linting * Fix exception check Co-authored-by: Michael Adkins <[email protected]>
encode · Dec 30, 2022 · 4cbf13e · 4cbf13e
1 parent 10a3b68
commit 4cbf13e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/httpx/_utils.py b/httpx/_utils.py
@@ -67,7 +67,11 @@ def primitive_value_to_str(value: "PrimitiveData") -> str:
         return "false"
     elif value is None:
         return ""
-    return str(value)
+    elif isinstance(value, (str, float, int)):
+        return str(value)
+    raise TypeError(
+        f"Expected str, int, float, bool, or None. Got {type(value).__name__!r}."
+    )
 
 
 def is_known_encoding(encoding: str) -> bool:

diff --git a/tests/models/test_queryparams.py b/tests/models/test_queryparams.py
@@ -87,6 +87,13 @@ def test_empty_query_params():
     assert str(q) == "a="
 
 
+def test_invalid_query_params():
+    with pytest.raises(
+        TypeError, match=r"Expected str, int, float, bool, or None. Got 'bytes'."
+    ):
+        httpx.QueryParams({"a": b"bytes"})
+
+
 def test_queryparam_update_is_hard_deprecated():
     q = httpx.QueryParams("a=123")
     with pytest.raises(RuntimeError):