-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default port for the socks5h scheme #972
Conversation
Can add sync and async tests for |
Thanks. Do you know implementation would need to change in establishing the connection in |
I don't think so:
|
We do already use "proxy resolves the hostname" behaviour, so our SOCKS support is "sock5h". https://superuser.com/questions/1762341/does-chromium-not-support-socks5h-with-the-h-in-the-end It's not obvious that we should add a synonym to the protocol name. (Staying in line with chromium's behaviour here seems reasonable, perhaps?) |
It is true that |
Okay yep.
|
I think you are looking at the wrong revision? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, yep.
Thanks! 🙏🏼
@tomchristie Could you revisit encode/httpx#3178 after merging this PR? I think this might have been the blocker. |
Summary
This change is needed to unblock encode/httpx#3178 and support
socks5h
scheme (server-side hostname resolution socks5 proxy). Support for thesocks5h
is needed to ensure global environment variables likeall_proxy="socks5h://..."
can be used reliably with different programs (some of which are httpx based).Checklist