Port becomes optional #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeraydiazdiaz
approved these changes
May 20, 2020
| @@ -51,7 +51,7 @@ class AsyncHTTPProxy(AsyncConnectionPool): | |||
|
|
|||
| def __init__( | |||
| self, | |||
| proxy_origin: Origin, | |||
| proxy_url: URL, | |||
There was a problem hiding this comment.
OMG thanks! 😅
The docstring above needs to be updated.
florimondmanca
approved these changes
May 21, 2020
|
|
||
| def url_to_origin(url: URL) -> Origin: | ||
| scheme, host, explicit_port = url[:3] | ||
| default_port = {b'http': 80, b'https': 443}[scheme] |
There was a problem hiding this comment.
I was curious why Black didn't cough up on this usage of single quotes, only to realize it's not run in scripts/check.
It's been a while since I've been around here but I assume it (and the isort check) was removed on purpose from there?
Edit: OK, looks like we're planning to introduce black and flake8 back in #67
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tuple[bytes, bytes, int], since we need a canonical form there.proxy_originbecomesproxy_urlfor better consistency.HTTPX would need to update the
proxy_originform it uses toproxy_url.