-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.17.1 #685
Version 0.17.1 #685
Conversation
Great, thanks! The bullet points here are describing implementation changes, rather than the (user-facing) behaviour.
(What do you think?) This also prompts a suggested procedure improvement... we should start ensuring that pull requests update the release notes. |
Okay, here's a release draft based on your CHANGELOG here... https://github.com/encode/httpcore/releases/tag/untagged-b7d3a9dd34c002f475be Does this all look correct? |
@tomchristie Thanks for your suggestions regarding changelog. Unfortunately, I cannot access https://github.com/encode/httpcore/releases/tag/untagged-b7d3a9dd34c002f475be, probably it is accessible only for maintainers. PS Sorry for the delayed reply, I prepared a reply right after my last commit, but forgot to press comment button 😞 |
Looks good, let's go on this. (Also, I've sent you an invite to @encode/maintainers which you're welcome to either accept or decline.) |
Cool, thanks! |
@tomchristie Just to double check: could I publish https://github.com/encode/httpcore/releases/tag/untagged-b7d3a9dd34c002f475be (it looks like now I have enough permissions for this), or are you going to do it by yourself later on? I looked at it, and it looks good. |
I've added #688 to https://github.com/encode/httpcore/releases/tag/untagged-4c24a8601913f6ed346b |
Okay, you're welcome to hit "publish" on the release if you'd like. I'll show how the workflow proceeds after that. |
Thanks, done! |
Great, so... Our publish workflow: https://github.com/encode/httpcore/actions/runs/5005203672 Has initiated this action: https://github.com/encode/httpcore/actions/runs/5005203672 Once someone from the @encode/operations team approves that action (which I've just done), the action runs, and should deploy the release to PyPI. We should probably create an issue for a docs page or repository markdown document describing the contribution and release processes. |
Hi @tomchristie,
It is a PR for a new release, based on #661 and #640 as examples.
I am not sure whether any checklist is needed: 1) #669, #678 and #679 have already been merged 2) The date has been filled in.
Also, I am not able to create a draft of GH release, but I hope it is not a problem.