Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mypy from 0.981 to 0.991 #634

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 1, 2022

Bumps mypy from 0.981 to 0.991.

Commits
  • b7788fc Update version to remove "+dev" for releasing 0.991
  • 6077d19 manually CP typeshed #9130
  • ab0ea1e Fix crash with function redefinition (#14064)
  • 592a9ce Fix another crash with report generation on namespace packages (#14063)
  • 1650ae0 Update --no-warn-no-return docs for empty body changes (#14065)
  • b9daa31 Don't ignore errors in files passed on the command line (#14060)
  • 02fd8a5 Filter out wasm32 wheel in upload-pypi.py (#14035)
  • 131c8d7 Fix crash on inference with recursive alias to recursive instance (#14038)
  • 1368338 Change version to 0.991+dev in preparation for the point release
  • b71dc3d Remove +dev from version
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 1, 2022
@dependabot dependabot bot force-pushed the dependabot/pip/mypy-0.991 branch from 41c765a to 0a68d78 Compare December 1, 2022 12:10
Bumps [mypy](https://github.com/python/mypy) from 0.981 to 0.991.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v0.981...v0.991)

---
updated-dependencies:
- dependency-name: mypy
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/mypy-0.991 branch from 0a68d78 to 539c169 Compare December 1, 2022 12:12
@tomchristie
Copy link
Member

tomchristie commented Dec 2, 2022

Failing with the following...

+ isort --check --diff --project=httpcore httpcore tests
Skipped 2 files
+ black --exclude /(_sync|sync_tests)/ --check --diff --target-version=py37 httpcore tests
All done! ✨ 🍰 ✨
35 files would be left unchanged.
+ flake[8](https://github.com/encode/httpcore/actions/runs/3592468782/jobs/6048216210#step:5:9) httpcore tests
+ mypy httpcore tests
httpcore/_models.py:444: error: Unused "type: ignore" comment
httpcore/_models.py:483: error: Unused "type: ignore" comment
httpcore/_sync/connection_pool.py:352: error: Unused "type: ignore" comment
httpcore/_async/connection_pool.py:352: error: Unused "type: ignore" comment
Found 4 errors in 3 files (checked 51 source files)
Error: Process completed with exit code 1.

Not clear why mypy's behaviour would change there, but looks like we can remove some type: ignore comments with this version upgrade.

Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dependabot.

@tomchristie tomchristie merged commit 54f4485 into master Dec 8, 2022
@tomchristie tomchristie deleted the dependabot/pip/mypy-0.991 branch December 8, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant