Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eg. AsyncByteStream(content=b'...') #127

Merged
merged 3 commits into from
Aug 2, 2020

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Aug 2, 2020

Nicer base class implementations for AsyncByteStream and SyncByteStream.

Allows for eg AsyncByteStream(content=b'...') usages.

Closes #125

Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! 👍

@florimondmanca
Copy link
Member

Any docs changes required here too…?

@tomchristie
Copy link
Member Author

@florimondmanca - Nope, should all be picked up by our autodocs. We've not got great documentation around using the interface, but addressing that more fully is something for a different day! :)

@tomchristie tomchristie merged commit 23e3cbe into master Aug 2, 2020
@tomchristie tomchristie deleted the support-simple-content-on-byte-streams branch August 2, 2020 11:39
@tomchristie tomchristie mentioned this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add content=b"" to base stream implementations.
2 participants