Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consideration.
We might want to think again about having HTTP/2 be an optional install for our
httpx
1.0 release onwards.Done:
.connection
signature inAsyncHTTPConnection
.AsyncHTTP11Connection
orAsyncHTTP2Connection
as required.To do:
h2
inAsyncConnectionPool
ifhttp2=True
is set, so that we get nice early errors if it is not installed.h2
to an optional install, requiringpip install httpcore[http2]