-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add official support for Django 5.1 #9514
Conversation
Following the supported Python versions: https://docs.djangoproject.com/en/stable/faq/install/
[testenv:py38-djangomain] | ||
ignore_outcome = true | ||
|
||
[testenv:py39-djangomain] | ||
ignore_outcome = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't test Django main against 3.8 or 3.9 so this is unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right
Should we try to fix the issue with the new |
I think we should include that in this PR |
I initially went with a custom Additionally, I struggled a bit to test that solution as I couldn't find out a way to configure test views with a non-default I took a step back and realised that DRF already offered a way to achieve what What do people think of the approach? |
Very nice solution. I feel |
Added some more integration-like type of tests to make sure every type of views are covered: class based views, function based views, viewsets and viewsets actions. |
Description
Add Django 5.1 to the CI matrix following the supported Python versions and declare official support.