Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8771 - Checking for authentication even if _ignore_model_permissions = True #8772

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

dennybiasiolli
Copy link
Contributor

Description

Refs #8771 , refs #8425

We should check for authentication even when the _ignore_model_permissions flag is set to True.
Otherwise it will bypass the check for authentication, not only the one for permissions

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah It seems the perm check should be done first before resolving router

@auvipy auvipy merged commit c0d95cb into encode:master Nov 22, 2022
@dennybiasiolli dennybiasiolli deleted the fix-8871 branch November 22, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants