Version 3.14.0 proposal #8599

tim-schilling · 2022-08-10T15:12:07Z

Currently projects using Django 4.1 are blocked from using Django Rest Framework due to #8591. Since that was merged, I think a release is warranted.

I started putting together the changes from 3.13.1, and discovered there were a couple of API changes. I suspect this should require a minor version change, but a maintainer should make that final call.

If the version change isn't desired, let me know and I can remove that.

tomchristie · 2022-08-12T11:04:21Z

Good stuff, thanks Tim.
And yes, a 3.14 release makes sense.

I'd like #7522 to be part of this too, but would be great to get a review onto that from someone other than myself.

docs/community/release-notes.md

Co-authored-by: Adam Johnson <[email protected]>

Nta1e · 2022-08-30T15:18:08Z

@tomchristie can we release this? It's blocking upgrades to Django 4.1

tomchristie · 2022-08-31T10:51:00Z

Consideration... I suppose we might want to include #8617 for this release. Thoughts?

We also ought to add a https://www.django-rest-framework.org/community/3.14-announcement/ page to the docs.

mscansian · 2022-08-31T11:11:01Z

@tomchristie it would be nice to not delay too much the release of this version since it's actually blocking everyone from upgrading to Django 4.1

tim-schilling · 2022-08-31T13:20:00Z

I can add the community page this weekend. If #8617 isn't resolved by then, perhaps that goes in a 3.15 release when it does get merged?

Archmonger · 2022-09-02T09:53:07Z

I believe #8617 is now in a mergeable state. Should be able to make it in to the 3.14 release.

This deprecation was never released in the 3.13.x series and therefore can't be removed at the same time the replacement is released.

tim-schilling · 2022-09-07T15:00:47Z

I've added a draft for the community page, including the mention for #7522.

I also noticed that the warnings for RemovedInDRF314Warning were still being raised, so I removed the functionality that was scheduled for removal.

One thing that I caught was that the openapi _get_reference warning was introduced into the master branch, but never released. Since the deprecation is being released in version 3.14, we can't remove the call in 3.14 as well. I've created a new class for RemovedInDRF315Warning and switched _get_reference to reference that instead.

adamchainz · 2022-09-07T18:51:04Z

rest_framework/__init__.py

 class RemovedInDRF314Warning(PendingDeprecationWarning):
    pass


I think this and the above RemovedInDRF313Warning can be removed? I cannot find any other references.

I kept it as per the comments in #8589.

That argument doesn't really convince me, DRF has never kept around the old warning classes for previous versions, e.g. RemovedInDRF312Warning was removed in d45e000. Similarly, Django does not keep around old warning classes "just in case".

I'd rather leave that decision up to a maintainer. I wasn't a part of the original discussion so it'd be disingenuous for me to say that by convincing me, the past argument is moot.

Sorry to have missed this thread!

I was assuming that RemovedInDRF313Warning would be deleted with the 3.14 release.
(My point was only that deleting an exception class in a minor release would constitute a breaking change)

CC @adamchainz - put out a PR to delete the now-unused warnings: #8664

auvipy · 2022-09-09T11:20:30Z

docs/community/3.14-announcement.md

+
+Our requirements are now:
+
+* Python 3.6+


imho this should be 3.7+ but we need #8518 to be merged

Suggested change

* Python 3.6+

* Python 3.7+

I'd be happy merging that but I'll defer to @tomchristie.

auvipy · 2022-09-09T11:21:56Z

docs/community/3.14-announcement.md

+Our requirements are now:
+
+* Python 3.6+
+* Django 4.1, 4.0, 3.2, 3.1, 2.2 (LTS)


Suggested change

* Django 4.1, 4.0, 3.2, 3.1, 2.2 (LTS)

* Django 4.1, 4.0, 3.2 (LTS)

I can do the related clean ups in a separate PR as well.

spapas · 2022-09-13T11:26:59Z

Hello friends, do we have a timeline on when will the new release be released?

I think this should be prioritized because DRF can't be used with Django 4.1 because of the ValueError: The file 'rest_framework/css/bootstrap-theme.min.css.map' could not be found with <django.contrib.staticfiles.storage.ManifestStaticFilesStorage error.

Thank you and kind regards,
Serafeim

spapas · 2022-09-13T11:31:56Z

Also, are you working on a specific branch or tag for the 3.14 release ? I'd be happy to install it directly from github using the -e git+https://github.com... requirement if you point me to the correct branch. Could I use tim-schilling:version-3.14.0 ?

Thanks again

tomchristie · 2022-09-13T13:26:13Z

Hello friends, do we have a timeline on when will the new release be released?

It's right at the top of the list. Ought to be this week.

tomchristie · 2022-09-17T08:27:44Z

Ought to be this week.

Arrrgggh. Don't be too mean.
Getting there.

tim-schilling · 2022-09-21T13:14:40Z

Tom, what about the comments from the reviews? There were some good points that we were looking for your opinion on.

…

On Wed, Sep 21, 2022, 8:08 AM Tom Christie ***@***.***> wrote: Merged #8599 <#8599> into master. — Reply to this email directly, view it on GitHub <#8599 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJYZP2PQUZWAEOT34XDZK3V7MCEVANCNFSM56E5GBCQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

tim-schilling · 2022-09-21T13:24:55Z

I see the follow-up PR now and that you're on it! Thank you.

tomchristie · 2022-09-21T13:34:07Z

Okay... I'm ready for us to release this tomorrow unless there's any objections?

I've updated the release date in the docs to 22nd Sept 2022.

tim-schilling · 2022-09-21T13:43:27Z

@tomchristie is DRF's policy regarding RemovedInDRF<version>Warning changing? Adam brought up that the project hasn't kept the previous warning classes, but we still have RemovedInDRF314Warning hanging around currently.

DavidCain · 2022-09-21T18:17:02Z

@tomchristie is DRF's policy regarding RemovedInDRFWarning changing? Adam brought up that the project hasn't kept the previous warning classes, but we still have RemovedInDRF314Warning hanging around currently.

I responded in-thread, but also noting here:

The pattern in past releases has been to drop the old unused exception classes - I think we should do the same for 3.14.
I only kept RemovedInDRF313Warning around because 3.13 was released with that exception class still defined.

Would be best to not repeat the same strangeness with DRF 3.14. 😄

#8664

(Sorry for not being clear on my original PR)

gopackgo90 · 2022-09-22T00:47:09Z

It looks like Django 2.2 is being dropped, but the setup.cfg still looks like it allows for Django 2.2 both in the python_requires and classifiers.

https://github.com/encode/django-rest-framework/blob/master/setup.py#L85
https://github.com/encode/django-rest-framework/blob/master/setup.py#L92

I also would think dropping Django 2.2 should be added to the release notes.

tomchristie · 2022-09-22T11:44:01Z

Okay, released.

pauloxnet · 2022-09-22T13:07:24Z

Thanks for the release. 🙏️

MarkusH · 2022-09-22T13:09:15Z

Okay, released.

Wonderful. Thank you ❤️

* Version 3.14.0 * Update docs/community/release-notes.md to use proper links. Co-authored-by: Adam Johnson <[email protected]> * Add community announcement page for version 3.14 * Remove deprecated NullBooleanField. * Change openapi _get_reference removal to 3.15 This deprecation was never released in the 3.13.x series and therefore can't be removed at the same time the replacement is released. * Removing deprecated openapi methods. Co-authored-by: Adam Johnson <[email protected]>

Version 3.14.0

e89cba2

Nta1e mentioned this pull request Aug 16, 2022

error when collecting static files #8609

Closed

3 tasks

adamchainz reviewed Aug 17, 2022

View reviewed changes

docs/community/release-notes.md Outdated Show resolved Hide resolved

Update docs/community/release-notes.md to use proper links.

e35d584

Co-authored-by: Adam Johnson <[email protected]>

shamoon mentioned this pull request Sep 7, 2022

Bump django from 4.0.7 to 4.1.1 paperless-ngx/paperless-ngx#1535

Closed

tim-schilling added 4 commits September 7, 2022 09:52

Add community announcement page for version 3.14

4d60fe5

Remove deprecated NullBooleanField.

d6b87b0

Change openapi _get_reference removal to 3.15

619485f

This deprecation was never released in the 3.13.x series and therefore can't be removed at the same time the replacement is released.

Removing deprecated openapi methods.

d3f5591

adamchainz reviewed Sep 7, 2022

View reviewed changes

wiwski mentioned this pull request Sep 8, 2022

Bump django from 4.0.6 to 4.1.1 betagouv/euphrosyne#296

Merged

auvipy requested changes Sep 9, 2022

View reviewed changes

adamchainz mentioned this pull request Sep 9, 2022

Upgraded Bootstrap to 3.4.1 and added CSS source maps #8591

Merged

ghickman mentioned this pull request Sep 9, 2022

Bump django to 4.1 opensafely-core/job-server#1996

Merged

dilyanpalauzov mentioned this pull request Sep 11, 2022

Release 3.13.2 version, stating explicitly that it does not work with Django 4.1 #8647

Closed

tomchristie mentioned this pull request Sep 15, 2022

Drop Python 3.6 Support #8518

Closed

tomchristie merged commit b658915 into encode:master Sep 21, 2022

tomchristie mentioned this pull request Sep 21, 2022

Update supported versions for 3.14 release #8662

Merged

tomchristie mentioned this pull request Sep 22, 2022

Update setup.py to drop Django 2.2 and update release notes #8666

Merged

J-Priebe mentioned this pull request Nov 19, 2022

Up drf-yasg version in demo project to fix breaking change with removal of NullBooleanField from DRF iMerica/dj-rest-auth#454

Merged

ghost mentioned this pull request Nov 22, 2022

Add support for DRF >= 3.14.0 tfranzel/drf-spectacular#865

Closed

apo5tol mentioned this pull request May 28, 2023

Django 4.2 support AltSchool/dynamic-rest#354

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version 3.14.0 proposal #8599

Version 3.14.0 proposal #8599

tim-schilling commented Aug 10, 2022

tomchristie commented Aug 12, 2022

Nta1e commented Aug 30, 2022

tomchristie commented Aug 31, 2022

mscansian commented Aug 31, 2022

tim-schilling commented Aug 31, 2022

Archmonger commented Sep 2, 2022 •

edited

Loading

tim-schilling commented Sep 7, 2022

adamchainz Sep 7, 2022

tim-schilling Sep 7, 2022

adamchainz Sep 7, 2022

tim-schilling Sep 8, 2022

DavidCain Sep 21, 2022

DavidCain Sep 21, 2022

auvipy Sep 9, 2022

adamchainz Sep 9, 2022

auvipy Sep 9, 2022

auvipy Sep 9, 2022

spapas commented Sep 13, 2022

spapas commented Sep 13, 2022 •

edited

Loading

tomchristie commented Sep 13, 2022

tomchristie commented Sep 17, 2022

tim-schilling commented Sep 21, 2022 via email

tim-schilling commented Sep 21, 2022

tomchristie commented Sep 21, 2022 •

edited

Loading

tim-schilling commented Sep 21, 2022

DavidCain commented Sep 21, 2022

gopackgo90 commented Sep 22, 2022

tomchristie commented Sep 22, 2022

pauloxnet commented Sep 22, 2022

MarkusH commented Sep 22, 2022

		class RemovedInDRF314Warning(PendingDeprecationWarning):
		pass

	* Django 4.1, 4.0, 3.2, 3.1, 2.2 (LTS)
	* Django 4.1, 4.0, 3.2 (LTS)

Version 3.14.0 proposal #8599

Version 3.14.0 proposal #8599

Conversation

tim-schilling commented Aug 10, 2022

tomchristie commented Aug 12, 2022

Nta1e commented Aug 30, 2022

tomchristie commented Aug 31, 2022

mscansian commented Aug 31, 2022

tim-schilling commented Aug 31, 2022

Archmonger commented Sep 2, 2022 • edited Loading

tim-schilling commented Sep 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spapas commented Sep 13, 2022

spapas commented Sep 13, 2022 • edited Loading

tomchristie commented Sep 13, 2022

tomchristie commented Sep 17, 2022

tim-schilling commented Sep 21, 2022 via email

tim-schilling commented Sep 21, 2022

tomchristie commented Sep 21, 2022 • edited Loading

tim-schilling commented Sep 21, 2022

DavidCain commented Sep 21, 2022

gopackgo90 commented Sep 22, 2022

tomchristie commented Sep 22, 2022

pauloxnet commented Sep 22, 2022

MarkusH commented Sep 22, 2022

Archmonger commented Sep 2, 2022 •

edited

Loading

spapas commented Sep 13, 2022 •

edited

Loading

tomchristie commented Sep 21, 2022 •

edited

Loading