Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce is_valid(raise_exception=False) as a keyword-only argument. #7952

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Enforce is_valid(raise_exception=False) as a keyword-only argument. #7952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edbb7a4
make raise_exception a keyword-only argument
ProstoMaxim Apr 25, 2021
52f3c77
make raise_exception keyword-only in metaclass
ProstoMaxim Apr 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rest_framework/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def save(self, **kwargs):

return self.instance

def is_valid(self, raise_exception=False):
def is_valid(self, *, raise_exception=False):
assert hasattr(self, 'initial_data'), (
'Cannot call `.is_valid()` as no `data=` keyword argument was '
'passed when instantiating the serializer instance.'
Expand Down Expand Up @@ -712,7 +712,7 @@ def save(self, **kwargs):

return self.instance

def is_valid(self, raise_exception=False):
def is_valid(self, *, raise_exception=False):
# This implementation is the same as the default,
# except that we use lists, rather than dicts, as the empty case.
assert hasattr(self, 'initial_data'), (
Expand Down