Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop ignoring test outcome for Django 3.2 #7927

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

adamchainz
Copy link
Contributor

It has been released!

Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

CI: 👀

@adamchainz
Copy link
Contributor Author

There is still one failure from a warning raised in django-guardian. @smithdc1 already made a pre-emptive PR there back in October - django-guardian/django-guardian#721 - it's just not released yet.

We could ignore that one warning.

@carltongibson
Copy link
Collaborator

Ah, yes, the periodic Guardian is not updated shuffle™ — Yes, skip/ignore as needed.

@adamchainz
Copy link
Contributor Author

It seems guardian is only installed in tests as an example of a permissions backend that supports object-level permissions. We could also rewrite the tests to not rely on it.

@carltongibson
Copy link
Collaborator

@adamchainz — I think if you have a burst of energy for that it would save this issue coming up… (it's not often but...)

@adamchainz
Copy link
Contributor Author

I am done for the day here but will come back to this and evaluate my energy levels then.

Copy link
Contributor

@terencehonles terencehonles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering how Django 3.2 was being specified, and since you're touching this file does it make sense to also adjust the django32 specification from Django>=3.2a1,<4.0 to Django>=3.2,<4.0?

I would have commented directly on the line, but GitHub doesn't allow that.

@carltongibson
Copy link
Collaborator

carltongibson commented Apr 17, 2021

@adamchainz It may not be worth the cycles to rewrite the tests here right now. For reference here's a previous iteration 524a28c (you can see it's not a frequent issue) Up to you. 🙂 🥇

@johnthagen
Copy link
Contributor

@adamchainz @carltongibson A new django-guardian has been published: https://pypi.org/project/django-guardian/2.4.0/

Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnthagen

@adamchainz(-bot) rebase & merge 😀

@adamchainz adamchainz force-pushed the stop_ignoring_django_3.2 branch from c0fd2a7 to cfa76bd Compare June 21, 2021 10:23
@adamchainz adamchainz merged commit e92016a into encode:master Jun 21, 2021
@adamchainz adamchainz deleted the stop_ignoring_django_3.2 branch June 21, 2021 10:33
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants