Openapi custom operation name #7190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @gnuletik.
I think this is a good step.
- Let's promote
_get_operation_id()toget_operation_id()and document it to be overridden. - Then add
get_operation_id_base(), which just allows people to add logic instead of using the model name. - Then call the
__init__()kwargoperation_id_base.
Make sense? I think that will give the right level of flexibility for the future.
gnuletik
force-pushed
the
openapi-custom-operation-name
branch
from
8bebf03 to
a36232a
Compare
|
Hi @carltongibson, Thanks for the feedback! |
* rename operation_name with operation_id_base * add get_operation_id_base * get_operation_id not private * update docs * update tests
gnuletik
force-pushed
the
openapi-custom-operation-name
branch
from
a36232a to
03d3406
Compare
|
Thanks for the heads up @dhaval-mehta ! |
carltongibson
approved these changes
Mar 2, 2020
Closed
6 tasks
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow the user to customize the operationId's name.
It fixes the subtask " Allow setting a custom operation ID on views with an attribute?" defined here #6549
Thanks !