Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropped Python 3.4 support #6620

Merged
merged 12 commits into from
May 6, 2019
Merged

Dropped Python 3.4 support #6620

merged 12 commits into from
May 6, 2019

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Apr 30, 2019 •
edited
Loading

can be merged after python 2.7 support from master

CC @carltongibson

carltongibson
carltongibson reviewed Apr 30, 2019
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@xordoquy
Copy link
Collaborator

xordoquy commented Apr 30, 2019 •
edited by rpkilby
Loading

@auvipy
Copy link
Member Author

auvipy commented Apr 30, 2019

pulling and fixing the conflicts now

@auvipy
Copy link
Member Author

auvipy commented May 1, 2019

@carltongibson could you push the isort fix to get this merged?

jdufresne
jdufresne reviewed May 1, 2019
View reviewed changes
Copy link
Contributor

@jdufresne jdufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove:

./tests/test_fields.py:95:    @unittest.skipUnless(typing, 'requires python 3.5')

setup.py Outdated Show resolved Hide resolved
@jdufresne @auvipy
Update setup.py
23db0be 
Co-Authored-By: auvipy <[email protected]>
@auvipy
Copy link
Member Author

auvipy commented May 1, 2019

You can also remove:

./tests/test_fields.py:95:    @unittest.skipUnless(typing, 'requires python 3.5')

OK, thanks for the review :)

@auvipy
Copy link
Member Author

auvipy commented May 3, 2019

I think it's ready for merge! @tomchristie

rpkilby
rpkilby requested changes May 6, 2019
View reviewed changes
Copy link
Member

@rpkilby rpkilby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also drop Python 3.4 from docs/index.md? Otherwise, looks good to me.

@auvipy
Copy link
Member Author

auvipy commented May 6, 2019

sure! doing so ASAP

@auvipy
Copy link
Member Author

auvipy commented May 6, 2019

changes pushed.

@rpkilby rpkilby added this to the 3.10 Release milestone May 6, 2019
@rpkilby rpkilby merged commit 50a24d6 into encode:master May 6, 2019
@rpkilby
Copy link
Member

rpkilby commented May 6, 2019

Thanks!

@auvipy auvipy deleted the 34 branch May 6, 2019 18:39
@n2ygk n2ygk mentioned this pull request Jun 7, 2019
Closed
@buko106 buko106 mentioned this pull request Sep 11, 2019
Merged
terencehonles pushed a commit to terencehonles/django-rest-framework that referenced this pull request Oct 8, 2020
@auvipy @terencehonles
Drop Python 3.4 support (encode#6620)
b5d5a56
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
@auvipy
Drop Python 3.4 support (encode#6620)
ce902da
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
@auvipy @sigvef
Drop Python 3.4 support (encode#6620)
b5c898f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson left review comments

@rpkilby rpkilby rpkilby approved these changes

@jdufresne jdufresne jdufresne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.10 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@auvipy @xordoquy @rpkilby @carltongibson @jdufresne