Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify import_from_string() with Django's import_string() #6617

Merged
merged 1 commit into from
May 1, 2019
Merged

Simplify import_from_string() with Django's import_string() #6617

merged 1 commit into from
May 1, 2019

Conversation

jdufresne
Copy link
Contributor

No description provided.

@auvipy auvipy mentioned this pull request Apr 30, 2019
Merged
carltongibson
carltongibson approved these changes May 1, 2019
View reviewed changes
Copy link
Collaborator

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@carltongibson
Copy link
Collaborator

Grrr. Needs a rebase.

@jdufresne
Copy link
Contributor Author

Rebased 🙂

rpkilby
rpkilby approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@rpkilby rpkilby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@rpkilby rpkilby merged commit e16273a into encode:master May 1, 2019
terencehonles pushed a commit to terencehonles/django-rest-framework that referenced this pull request Oct 8, 2020
@jdufresne @terencehonles
Simplify import_from_string() with Django's import_string() (encode#6617
84c3ad5 
)
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
@jdufresne
Simplify import_from_string() with Django's import_string() (encode#6617
05468e7 
)
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
@jdufresne @sigvef
Simplify import_from_string() with Django's import_string() (encode#6617
9d41330 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpkilby rpkilby rpkilby approved these changes

@carltongibson carltongibson carltongibson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdufresne @carltongibson @rpkilby