Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.9 #6247

Merged
merged 14 commits into from
Oct 18, 2018
Merged

Version 3.9 #6247

merged 14 commits into from
Oct 18, 2018

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Oct 16, 2018

Let's get this show on the road, part 2. (Part 1 is #6119)

This is the Release PR for v3.9. Expected 1st Oct

Checklist:

  • Create pull request for release notes based on the 3.9 milestone.
  • Merge or bump remaining issues/PR from milestone.
  • Complete release notes.
  • Write 3.9 release announcement.
    • Viewset Extra Actions
    • OpenAPI
    • Composable Permissions
    • Deprecations etc.
  • Update supported versions:
    • setup.py python_requires list
    • setup.py Python & Django version trove classifiers
    • README Python & Django versions
    • docs Python & Django versions
  • Update the translations from transifex.
  • Ensure the pull request increments the version to 3.9.0 in restframework/__init__.py.
  • Confirm with @tomchristie that release is finalized and ready to go.
  • Ensure that release date is included in pull request.
  • Merge the release pull request.
  • Push the package to PyPI with ./setup.py publish.
  • Tag the release, with git tag -a *.*.* -m 'version 3.9.0'; git push --tags.
  • Deploy the documentation with mkdocs gh-deploy.
  • Make a release announcement on the discussion group.
  • Make a release announcement on twitter.
  • Close the milestone on GitHub.

@tomchristie tomchristie mentioned this pull request Oct 16, 2018
24 tasks
@tomchristie tomchristie added this to the 3.9 Release milestone Oct 16, 2018
@tomchristie
Copy link
Member Author

I think we're about good to finalize things here.
All okay with you folks @carltongibson, @xordoquy, @rpkilby?

@xordoquy
Copy link
Collaborator

probably the translations are to be updated.

@carltongibson
Copy link
Collaborator

I was expecting some mention of how to use APIStar to generate static docs.

Other than that (and a tx update yes) looks good.

@tomchristie
Copy link
Member Author

@carltongibson Good call. I was kinda thinking about deferring that stuff to the next major release, but a bit of a riff on "build docs like so", "add stuff to your schema then validate it like so", and "here's a dynamic client library to can use" already makes sense at this point.

@tomchristie
Copy link
Member Author

Plus thinking about it, I think it makes sense to talk about ASGI in the "what's next", including mentions of Starlette and Uvicorn. (Esp. since there's potentially a migration path for Django to eventually add ASGI support)

@tomchristie
Copy link
Member Author

probably the translations are to be updated.

Been a while since I've done that, but followed the docs, and compilemessages doesn't appear to have made any changes to the repo, so I guess they're already good to go?

@xordoquy
Copy link
Collaborator

there should be a new language

@tomchristie
Copy link
Member Author

We're not changing any supported python/django versions with this release so checkmarked all those.

TODO: Tweak the lead intro to the release notes.

@tomchristie
Copy link
Member Author

there should be a new language

Anyone up for giving the language updates a go from their setup? (And pushing to this branch)

@xordoquy
Copy link
Collaborator

I won't have the time today :(

* Fixed Javascript `e.indexOf` is not a function error [#5982][gh5982]
* Fix schemas for extra actions [#5992][gh5992]
* Improved get_error_detail to use error_dict/error_list [#5785][gh5785]
* Imprvied URLs in Admin renderer [#5988][gh5988]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo Imprvied => Improved

@rpkilby
Copy link
Member

rpkilby commented Oct 16, 2018

We're not changing any supported python/django versions with this release so checkmarked all those.

We dropped Django 1.10 support and technically added Python 3.7 support (although no code changes required).

Anyone up for giving the language updates a go from their setup? (And pushing to this branch)

I haven't dealt with transifex (not even sure if I have access).

@rpkilby
Copy link
Member

rpkilby commented Oct 16, 2018

I added one minor issue to the milestone for consideration and added a few comments to this PR, but otherwise I think we're good to go.

@tomchristie
Copy link
Member Author

Going to defer a translation update to 3.9.1.

I'll merge this once the tests are passed, then planning to push the release in a coupla hours.

@tomchristie tomchristie merged commit 2c9c0f1 into master Oct 18, 2018
@tomchristie tomchristie deleted the version-3.9 branch October 18, 2018 09:38
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
* Release notes to 5174a26

* Update version for v3.9.0

* Removed exclude_from_schema per deprecation policy.

* Updated list_route() and detail_route() deprecations.

* Weakened to PendingDeprecationWarning for `base_name`

cc @rpkilby.

* Add (beginning of) 3.9 release announcement.

@tomchristie: Input on OpenAPI and What’s Next very welcome! :)

* Add announcement section for Extra Actions in Browsable API

* Update release notes and add deprecation note for Django Guardian backend.

* Add release note for encode#6073

* Add release notes to dd19a44

* Adding release notes

* Update 3.9 announcement

* Add Oct 18 release date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants