Always pass a valid rounding value #6107
Conversation
Fixes encode#6015 Prevent an exception in `quantize()` when monkey-patching the decimal library as cdecimal in Python 2 environments by always passing a valid (not None) `rounding` value to `quantize()`.
Codecov Report
@@ Coverage Diff @@
## master #6107 +/- ##
==========================================
+ Coverage 96.18% 96.18% +<.01%
==========================================
Files 128 128
Lines 17624 17636 +12
Branches 1459 1459
==========================================
+ Hits 16951 16963 +12
Misses 465 465
Partials 208 208 |
|
I'm tempted to close this per #5741 (comment), but my off the cuff reaction is that this seems like a clean way to support Python 2. |
rest_framework/fields.py
Outdated
| @@ -1135,11 +1135,12 @@ def quantize(self, value): | |||
| return value | |||
|
|
|||
| context = decimal.getcontext().copy() | |||
| rounding = context.rounding if self.rounding is None else self.rounding | |||
There was a problem hiding this comment.
I would add a note that this exists for Python 2 compatibility.
kbussell
force-pushed
the
6105-cdecimal-rounding
branch
3 times, most recently
from
3ef0da3 to
f09cd0c
Compare
kbussell
force-pushed
the
6105-cdecimal-rounding
branch
from
f09cd0c to
602eec8
Compare
|
Hi @rpkilby, I've added a comment and a test that exercises the code in Python 2.7 using cdecimal |
|
cc @tomchristie. Do you want to review this for the 3.9 release, since this will likely be the last release that supports Python 2.7 (#6230)? |
|
Thanks for taking the time to PR this! I think I'd like us to pass, particularly given how close we are to phasing out Python 2 here. I'd suggest explicitly using a DecimalField subclass on your serializers in order to support this use-case. |
Description
Fixes #6105
Prevent an exception in
quantize()when monkey-patching the decimallibrary as cdecimal in Python 2 environments by always passing a valid
(not None)
roundingvalue toquantize().