Fix schemas for extra actions #5992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rest_framework/views.py
Outdated
| # copy class-level schema to prevent instances using the same object | ||
| if 'schema' not in self.__dict__: | ||
| self.schema = deepcopy(self.schema) | ||
| self.schema.view = self |
There was a problem hiding this comment.
Can we do this in ViewInspector.__get__()? (The goal being to keep the api out out APIView, bar the minimal schema property.)
There was a problem hiding this comment.
Let me take a second look at this. It might be possible to do this with __set__
There was a problem hiding this comment.
Alright, updated the descriptor with a setter. This seems to work fine.
6 tasks
rpkilby
force-pushed
the
schema-creation
branch
2 times, most recently
from
17d42c6 to
df1d4b7
Compare
rpkilby
force-pushed
the
schema-creation
branch
2 times, most recently
from
d9b4f63 to
f3dd14e
Compare
|
@carltongibson - rebased/updated the PR. I've opted for a note in the shema docs instead of the viewset docs, given that the latter don't currently mention schemas. |
carltongibson
approved these changes
Jul 6, 2018
6 tasks
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
* Add failing test for extra action schemas * Add ViewInspector setter to store instances * Fix schema disabling for extra actions * Add docs note about disabling schemas for actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that view instances are operating on their own
schemainstance. Previously, all instances of the class were using a shared, class-level schema instance, and the descriptor was mutating the schema to ensure the most recently accessed view instance was set on the schema.