Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2466 Ref #5658
As per #2466, the
override_settings
integration was updating the APISettings object correctly but was not functioning as expected since the documented usagefrom rest_framework.settings import api_settings
is bound at import time.This PR adds a (failing) test checking compat and adjusts the code to refresh APISettings in place, rather than replace the instance.
override_settings
then works as expected.Fix was suggested by @daggaz — thanks for that! (PRs always welcome! 🙂)