Robust uniqueness checks. #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 91.49%@@ master #4217 diff @@
==========================================
Files 51 51
Lines 5538 5549 +11
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 5068 5077 +9
- Misses 470 472 +2
Partials 0 0
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uniqueness checks for an invalid value should quietly pass, as the value does not exist.
This allows other validators to correctly catch the invalid input and return an appropriate error message, rather than resulting in a hard 500 failure.
Closes #3381
Closes #3493