Set proper status code in AdminRenderer for the redirection after POST/DELETE requests.

[sasha0]

refs #4032

[xordoquy]

Seems legit. Will need to properly test to ensure it fixes the original issue.

[sasha0]

Should I add a test case for it?

[xordoquy]

I don't think it's necessary. The tests I was referring to are the one with "real" browsers just to make sure it works(tm) since 303 vs 302 difference is browser specific.

[tomchristie]

I think this thread could do with being a little more specific.
Does this change the browser behavior? If so, how?

[xordoquy]

@tomchristie Everything is explained in the definition of the 303 code. However, I think there should be a location header which I'm not sure is part of the response.

[tomchristie]

Fair enough, although still worth confirming if there are any behavioral changes.

[sasha0]

@xordoquy don't we set Location header for both types of responses here and here?

[tomchristie]

I'm happy with this change, once someone's confirmed if it makes any behavioral difference to the browser (ie. actually try it out and report on before and after) - if they're the same then great, let's have this as a valid semantic change. If there's differences in the behavior before and after then we can review those on their merits.

[jpadilla]

Just confirmed this does fix original issue.

Although behavior still seems off. Shouldn't we be redirecting back to /users/ after deleting?

[tomchristie]

Shouldn't we be redirecting back to /users/ after deleting?

I think that'd be a valid improvement on DELETE, sure.