Make tests pass on Windows too #3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 0.11b3's setup.py had an undeclared dependency on `py2exe` when running on Windows (see https://github.com/transifex/transifex-client/blob/0.11b3/setup.py#L23), which made it impossible to install without having a working `py2exe` to begin with. This has been fixed in 0.11 proper.
This gets rid of a file encoding bug that occurs on Windows boxes where the default implied encoding is cp1252, but the files themselves aren't. The actual patch that seems to fix this is PyCQA/isort@1057d5e but it seems like a good idea to upgrade to the latest and greatest.
This re-stabilizes sorting after upgrading to 4.2.2.
Windows Pythons seem to like printing addresses in upper-case, while Linux Pythons like lower-case hexes. This led to an amusing (for a given value of "amusing", anyway) situation where some repr tests would fail if the objects they were testing happened to be allocated at an address with a hex digit in the range A..F.
|
Thanks for the PR. LGTM. Looking forward to travis finishing the build. |
|
Nice! FWIW we use AppVeyor on https://github.com/jpadilla/pyjwt to run tests on Windows. |
|
Looks good. |
tomchristie
added a commit
that referenced
this pull request
Nov 26, 2015
Make tests pass on Windows too
|
Right now I don't have any particular pref for if we should be running the tests against windows too or not. Its a possibility tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are refined versions of the commits that previously lived in #3668.
Upgrade transifex-client dependency to 0.11
Version 0.11b3's setup.py had an undeclared dependency on
py2exewhen running on Windows (see https://github.com/transifex/transifex-client/blob/0.11b3/setup.py#L23), which made it impossible to install without having a workingpy2exeto begin with.This has been fixed in 0.11 proper.
Upgrade isort to 4.2.2.
This gets rid of a file encoding bug that occurs on Windows boxes where the default implied encoding is cp1252, but the files themselves aren't. The actual patch that seems to fix this is
PyCQA/isort@1057d5e
but it seems like a good idea to upgrade to the latest and greatest.
Add
typesto isort's standard library list.This re-stabilizes sorting after upgrading to 4.2.2.
Fix
smart_repr()to also clean upper-case hex addresses.Windows Pythons seem to like printing addresses in upper-case, while Linux Pythons like lower-case hexes.
This led to an amusing (for a given value of "amusing", anyway) situation where some repr tests would fail if the objects they were testing happened to be allocated at an address with a hex digit in the range A..F.