Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Guardian testing against Django master #3427

Merged
merged 1 commit into from
Sep 22, 2015

Conversation

carltongibson
Copy link
Collaborator

Fixes #3406

Excluding Django Guardian clears up the test run against Django master

3 failed, 287 passed, 2 warnings, 456 error in 220.90 seconds

vs

1 failed, 735 passed, 10 skipped, 2 warnings in 7.39 seconds

  • Made against v3.3 branch.
  • Easy enough to re-add when Guardian fixes this.
  • There's probably some neater way of specifying the exclude in tox config — but I couldn't think of it offhand.

@tomchristie
Copy link
Member

Wonderful!

@carltongibson
Copy link
Collaborator Author

@tomchristie Glad you like it. :)

@tomchristie
Copy link
Member

The failure there should be easy enough to resolve - something on ModelSerializer is being mapped slightly diff between versions. Would be good to fully see the diff between the actual repr() and the expected repr()

@carltongibson
Copy link
Collaborator Author

Yes — at least the output of the run is short enough to look at sensibly here. I'll create a new issue for that.

tomchristie added a commit that referenced this pull request Sep 22, 2015
Exclude Guardian testing against Django master
@tomchristie tomchristie merged commit eccf7cc into encode:version-3.3 Sep 22, 2015
@xordoquy
Copy link
Collaborator

👍 nice job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants