Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in browsable API on error. #3179

Merged
merged 3 commits into from
Jul 23, 2015
Merged

Errors in browsable API on error. #3179

merged 3 commits into from
Jul 23, 2015

Conversation

tomchristie
Copy link
Member

Closes #3024.
Refs #2926.

Example:

image

@tomchristie tomchristie added this to the 3.1.4 Release milestone Jul 23, 2015
tomchristie added a commit that referenced this pull request Jul 23, 2015
@tomchristie tomchristie merged commit 9d136ab into master Jul 23, 2015
@tomchristie tomchristie deleted the browsable-api-errors branch July 23, 2015 14:25
@jpadilla
Copy link
Member

@tomchristie just wondering, why the changes needed in _force_text_recursive()?

@tomchristie
Copy link
Member Author

@jpadilla - We're raising the errors as ValidationErrors. The force_text_recursive allows the internationalized strings to be realized into a particular language, but we're losing the associated backlink to the serializer in the process.

@tomchristie
Copy link
Member Author

Can't lie - the form error handling isn't the most graceful, but we do what needs to be done. One area for gradual improvement once the big functionality pieces are done & dusted.

@tomchristie tomchristie modified the milestones: 3.1.4 Release, 3.2.0 Release Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants