-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no pk issue #2638 #2641
Fix no pk issue #2638 #2641
Conversation
I second @thedrow's comment on #2639 that there should be a test case here. It needs to demonstrate the issue that's being fixed. It should fail without the patch and pass with it. Such tests bring to light the expected behaviour — they help to decide if that's the behaviour we want. (They also catch regressions down the line.) My immediate thought though is that this looks similar to #2637 so we need to make sure we're not making two related changes where one is required. (That's another way the test would help.) |
Closing as per comment on #2638 |
Updated patch addressing @thedrow 's comments.