Cleanup '.model' shortcut from code and docs #2486
Conversation
|
Looks good, yup! Tho presumably some digging needed to figure out why the tests are failing. |
|
Yes, I'm surprised I managed to fail the whole build with a 2 line change o_O |
|
Ok, I really don't get what's up. Anyone has any suggestions? |
|
@maryokhin Do the tests run okay for you locally? |
|
@tomchristie no, have the same issue locally, so it's probably my miss somewhere, just don't get how that's possible in 2 lines of code >_< |
|
|
||
| assert model_cls, '`base_name` argument not specified, and could ' \ | ||
| assert queryset, '`base_name` argument not specified, and could ' \ |
There was a problem hiding this comment.
Should we instead be using assert queryset is not None here? Are we accidentally evaluating the queryset?
There was a problem hiding this comment.
Yes, that was the issue, assert was evaluating the queryset, whose implementation fetches from the DB if it's not in the cache. Correct implementation exposed some old tests using .model, so I'll rebase and fix those along the way too.
|
One inline comment with a possibility. Failing that I guess narrow this down to single step changes. (Roll back to the original, run the tests for sanity, then just change one line of a code at a time, running the tests after each change) |
|
This looks good to me now. |
Cleanup '.model' shortcut from code and docs
As far as I understand, if it was removed, then mentioning it in the docs will just confuse people.