Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client.logout() also cancels any existing force_authenticate. #2259

Merged
merged 3 commits into from
Dec 12, 2014

Conversation

tomchristie
Copy link
Member

Closes #2218.

@tomchristie tomchristie added this to the 3.0.2 Release milestone Dec 12, 2014
@xordoquy
Copy link
Collaborator

Given the inconsistence we are probably missing a few from __future__ import unicode_literals statements in the code.

self.assertEqual(response.data['user'], 'example')
self.client.logout()
response = self.client.get('/view/')
self.assertEqual(response.data['user'], b'')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example is a text type (previous assert) while b'' is binary

@tomchristie
Copy link
Member Author

Yeah, we could clean that up at some point & ensure that every module starts with...

# encoding: utf-8
from __future__ import unicode_literals

tomchristie added a commit that referenced this pull request Dec 12, 2014
…els-force-authenticate

`Client.logout()` also clears any `force_authenticate`
@tomchristie tomchristie merged commit fd473aa into master Dec 12, 2014
@tomchristie tomchristie deleted the testclient-logout-also-cancels-force-authenticate branch December 12, 2014 13:33
@tomchristie tomchristie changed the title Client.logout() also clears any force_authenticate Client.logout() also cancels any existing force_authenticate. Dec 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client.logout() also cancels any existing force_authenticate.
2 participants