-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes & version 3.0.1 #2251
Conversation
I noticed that we are including the ticket numbers in the release notes (which is great!), maybe we should link the numbers to the actual tickets? |
@kevin-brown I was just about to say that 👍 |
* More helpful error message when the default `.create` fails (#2013) | ||
* Raise error when attempting to save serializer if data is not valid. (#2098) | ||
* Fix `FileUploadParser` breaks with empty file names and multiple upload handlers (#2109) | ||
* Imporve BindingDict to support standard dict-functions (#2135, #2163) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imporve - > Improve
Also: full stops at the end of all items. |
@@ -40,6 +40,32 @@ You can determine your currently installed version using `pip freeze`: | |||
|
|||
## 3.0.x series | |||
|
|||
### 3.0.1 | |||
|
|||
**Date**: [December 2014](https://github.com/tomchristie/django-rest-framework/issues?q=milestone%3A%223.0.1+Release%22) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got lazy about this myself, but we prob oughta go with the [Text][ref]
... [ref]: url
link style throughout.
So [December 2014][3.0.1-milestone]
with [3.0.1-milestone]: https://github.com/tomchristie/django-rest-framework/issues?q=milestone%3A%223.0.1+Release%22
at the bottom of the document.
Don't mind fixing all these up myself tho since it's my fault for getting lazy about it in previous versions.
Add link to the issues Fix the milestone link
ok, I think this should be fine now. |
* More helpful error message when the default Serializer `create()` fails. ([#2013](https://github.com/tomchristie/django-rest-framework/issues/2013)) | ||
* Raise error when attempting to save serializer if data is not valid. ([#2098](https://github.com/tomchristie/django-rest-framework/issues/2098)) | ||
* Fix `FileUploadParser` breaks with empty file names and multiple upload handlers. ([#2109](https://github.com/tomchristie/django-rest-framework/issues/2109)) | ||
* Improve BindingDict` to support standard dict-functions. ([#2135](https://github.com/tomchristie/django-rest-framework/issues/2135), [#2163](https://github.com/tomchristie/django-rest-framework/issues/2163)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where @jpadilla was referencing.
Wondering if we'd also need to fix the [Link][ref] for the ticket numbers. Might be kinda of an annoyance and unnecessary to keep that up in the future. |
@jpadilla I think we should - it'll be easier to review as correct, and we can keep them all numerically ordered in the index at the bottom. Eg:
I'm happy to fix that up after this pull request in order to get the release out, or it can be handled now. Either would be fine. |
Indeed, it'll be easier for later. |
so, there it is. Anything more ? |
* More helpful error message when the default Serializer `create()` fails. ([#2013][gh2013]) | ||
* Raise error when attempting to save serializer if data is not valid. ([#2098][gh2098]) | ||
* Fix `FileUploadParser` breaks with empty file names and multiple upload handlers. ([#2109][gh2109]) | ||
* Improve BindingDict` to support standard dict-functions. ([#2135][gh2135], [#2163][gh2163]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing backtick. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn it. I swear I added a backtick. Might be somewhere else ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Behind the sofa.
Release notes & version 3.0.1
We are go. |
It's ready except for #2197 which will contradict the deprecation policy.