Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_blank for ChoiceField #2184 #2239

Merged
merged 1 commit into from
Dec 9, 2014
Merged

Add allow_blank for ChoiceField #2184 #2239

merged 1 commit into from
Dec 9, 2014

Conversation

jpadilla
Copy link
Member

@jpadilla jpadilla commented Dec 9, 2014

This makes a ChoiceField optional in HTML if model field has blank=True set.

Closes #2184.

This makes a ChoiceField optional in HTML if
model field has `blank=True` set.
@tomchristie
Copy link
Member

Perfect!

@tomchristie tomchristie added this to the 3.0.1 Release milestone Dec 9, 2014
@tomchristie tomchristie added the Bug label Dec 9, 2014
tomchristie added a commit that referenced this pull request Dec 9, 2014
@tomchristie tomchristie merged commit 54a18a4 into encode:master Dec 9, 2014
@jpadilla
Copy link
Member Author

jpadilla commented Dec 9, 2014

We'll also need to update the signature for ChoiceField to include allow_blank

@tomchristie
Copy link
Member

Kk, I'll get on that.

tomchristie added a commit that referenced this pull request Dec 9, 2014
@tomchristie
Copy link
Member

Done.

@jpadilla jpadilla deleted the allow-blank-choicefield branch December 9, 2014 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChoiceField with required=False not optional in HTML view
2 participants