Added test to simulate an error I had where an imported reference failed... #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led and the python property swallowed the exception raised in my authenticator.
…all for "request.user".
| try: | ||
| self._authenticate() | ||
| except AttributeError as error: | ||
| raise RuntimeError("AttributeError: " + error.message) |
There was a problem hiding this comment.
I think you can still keep the existing traceback which will be useful for debugging by using six.reraise. I think it would look like:
six.reraise(RuntimeError, "AttributeError: " + str(error), sys.exc_info()[2])
And error.message is not available in Python 3. You should use the str(error) instead.
|
Looks like this needs updating to latest master. |
|
Superseeded by #2530, which includes your test. Thanks for your work on this! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and the python property swallowed the exception raised in my authenticator.