Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docfix: update installation example to work with django 1.6 #1274

Merged
merged 1 commit into from
Dec 7, 2013

Conversation

wilsaj
Copy link
Contributor

@wilsaj wilsaj commented Dec 7, 2013

looks like django.conf.urls.defaults was deprecated as of django 1.6: https://docs.djangoproject.com/en/1.6/internals/deprecation/#id1

looks like django.conf.urls.defaults was deprecated as of django 1.6
tomchristie added a commit that referenced this pull request Dec 7, 2013
docfix: update installation example to work with django 1.6
@tomchristie tomchristie merged commit 14ae301 into encode:master Dec 7, 2013
@tomchristie
Copy link
Member

Great, thank you!

@qooleot qooleot mentioned this pull request Dec 8, 2013
@qooleot
Copy link
Contributor

qooleot commented Dec 8, 2013

I'm sorry for being slow (new to django, python, and the rest framework), as I might very well be reading this wrong.

django-rest-framework says it supports django 1.3, but I think django.conf.urls only appeared in 1.4:

https://docs.djangoproject.com/en/1.4/topics/http/urls/

I don't know if you're soon to be dropping 1.3, now that 1.6 is out and we should ignore this, or alternatively I can create a tiny pull request to add a small comment above the example?

@tomchristie
Copy link
Member

@qooleot - You're correct that the quickstart example won't be correct for 1.3 anymore, although 1.3 is still supported, and yup I think we can probably do without the note of 'In 1.3 this line should be....' since we'll be dropping it soon enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants