allow default boolean values to be honoured

[tomwalker]

In response to request #1101 "Default Boolean value always becomes False even default=True is specified in model class."

This allows a default to be used when the field is not specified in the request.

[LilyFoote]

Why not test both default=True and default=False?

[tomwalker]

Whilst following the recommendations from Ian-Foote (thanks by the way) I found another small bug - if a default was set but the field was not specified when the serialiser was initialised then it would return as None.

This is seen with this:

serializer = self.default_true_boolean_serializer({'cat': False})

[tomchristie]

Kick me on this thread if I've not reviewed this in the next few days :)

[kevin-brown]

Just a few quick things that are a problem with this pull request.

When serializers are initialized, the first argument is the instance. So in all of your tests, the data is not being passed into the serializer, so none of them are valid (you can test this by calling serializer.is_valid(), it returns False). Once you fix that issue, the tests should continue to break. They were all failing because no data could be processed, which is also why your first test is invalid, as it won't do data processing without data.

The last test (test_enabled_partial) does not specify the partial parameter on initialization, so that also failed to validate.

With all of that in mind, I created a new pull request (#1291) which fixes the issue in a different way.

[tomchristie]

Closing in favor of #1291. Thanks for the input!

[tomwalker]

Hi Kevin,

Thank you for taking the time to explain everything - it has been a great help.