Changed error to warning message

encode · Dec 17, 2015 · dab6bf4 · dab6bf4
1 parent fbd89d6
commit dab6bf4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/rest_framework/settings.py b/rest_framework/settings.py
@@ -17,6 +17,7 @@
 REST framework settings, checking for user settings first, then falling
 back to the defaults.
 """
+import warnings
 from __future__ import unicode_literals
 
 from django.conf import settings
@@ -216,7 +217,7 @@ def __check_user_settings(self, user_settings):
         SETTINGS_DOC = "http://www.django-rest-framework.org/api-guide/settings/"
         for setting in REMOVED_SETTINGS:
             if setting in user_settings:
-                raise AttributeError("The '%s' setting has been removed. Please refer to '%s' for available settings." % (setting, SETTINGS_DOC))
+                warnings.warn("The '%s' setting has been removed. Please refer to '%s' for available settings." % (setting, SETTINGS_DOC), DeprecationWarning)
         return user_settings
 
 

diff --git a/tests/test_settings.py b/tests/test_settings.py
@@ -18,15 +18,18 @@ def test_import_error_message_maintained(self):
         with self.assertRaises(ImportError):
             settings.DEFAULT_RENDERER_CLASSES
 
-    def test_loud_error_raised_on_removed_setting(self):
+    def test_warning_raised_on_removed_setting(self):
         """
         Make sure user is alerted with an error when a removed setting
         is set.
         """
-        with self.assertRaises(AttributeError):
+        with warnings.catch_warnings(record=True) as w:
+            warnings.simplefilter("always")
             APISettings({
                 'MAX_PAGINATE_BY': 100
             })
+            self.assertEqual(len(w), 1)
+            self.assertTrue(issubclass(w[-1].category, DeprecationWarning))
 
 
 class TestSettingTypes(TestCase):