Bring check for null fk to BaseSerializer.to_representation

encode · Mar 13, 2016 · 2ef74cf · 2ef74cf
1 parent cbb8d8d
commit 2ef74cf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/rest_framework/fields.py b/rest_framework/fields.py
@@ -778,8 +778,6 @@ def to_internal_value(self, data):
         return data
 
     def to_representation(self, value):
-        if value is None:
-            return None
         if self.uuid_format == 'hex_verbose':
             return str(value)
         else:

diff --git a/rest_framework/serializers.py b/rest_framework/serializers.py
@@ -464,9 +464,13 @@ def to_representation(self, instance):
             except SkipField:
                 continue
 
-            if attribute is None:
-                # We skip `to_representation` for `None` values so that
-                # fields do not have to explicitly deal with that case.
+            # We skip `to_representation` for `None` values so that fields do
+            # not have to explicitly deal with that case.
+            #
+            # For related fields with `use_pk_only_optimization` we need to
+            # resolve the pk value.
+            check_for_none = attribute.pk if isinstance(attribute, PKOnlyObject) else attribute
+            if check_for_none is None:
                 ret[field.field_name] = None
             else:
                 ret[field.field_name] = field.to_representation(attribute)