-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compress Option #32
Compress Option #32
Conversation
@@ -19,6 +20,7 @@ var EOL = require('os').EOL; | |||
* involved in the assembly. | |||
* @param {Boolean} [options.iife=false] Adds an option to wrap merged<br> | |||
* files to IIFE. | |||
* @param {Boolean} [options.compress=false] Minifies and compress JS code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Мы же обычно пишем что-то вроде: 'Set true to ...'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compress -> compresses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Мы же обычно пишем что-то вроде: 'Set true to ...'
Вроде бы нет :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я не совсем точно написал. Вот например из bemxjst: "Sets devMode
option for convenient debugging. If devMode
is set to true, code of templates will not be compiled but only wrapped for development purposes."
отписал |
здесь не возникнет дополнительных проблем с получением сорс-мапов в будущем? |
Возникнет, но uglify умеет работать с сорс-мапами. |
🆙 |
🆗 |
а для ноды сжатие имеет какой-то практический смысл? |
Думаю, что нет. Выпилить? |
если смысла нет, а при включении станет медленнее, то, кмк, лучше заранее не давать такой возможности |
удалил |
'/* end: ' + relPath + ' *' + '/' | ||
].join(EOL); | ||
|
||
// after compress comments will be removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compress -> compression
lgtm |
Resolved #30