-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug with impossible to exit #97
Conversation
1c1d294
to
8fd55eb
Compare
Ты просто поубирал весь код с process.exit? |
@tormozz48, да.
Всё остальное, включая этот пакет должно просто возвращать ошибку. |
} | ||
|
||
if (opts.coverage.engines.length > 0) { | ||
processCoverage(opts.coverage).done(resolvePromise); | ||
processCoverage(opts.coverage) | ||
.done(resolvePromise, resolvePromise); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Если мы тут получим fail
и внутри resolvePromise()
произойдет resolve()
, это нормально, что мы не увидем ошибки?
@unlok Исправил обработку
Очень похоже на gotwarlost/istanbul#402. Ошибка возникает, когда Если собирать примеры, то /сс @SevInf |
нужно отрибейзить по master |
Fixed bug with impossible to exit
Resolved #88