Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with impossible to exit #97

Merged
merged 1 commit into from
Aug 1, 2015
Merged

Fixed bug with impossible to exit #97

merged 1 commit into from
Aug 1, 2015

Conversation

blond
Copy link
Member

@blond blond commented Jul 15, 2015

Resolved #88

@blond blond added the review label Jul 15, 2015
@blond blond force-pushed the issue-88 branch 2 times, most recently from 1c1d294 to 8fd55eb Compare July 15, 2015 19:30
@blond
Copy link
Member Author

blond commented Jul 15, 2015

/cc @tadatuta @tormozz48 @unlok

@tormozz48
Copy link

Ты просто поубирал весь код с process.exit?

@blond
Copy link
Member Author

blond commented Jul 15, 2015

@tormozz48, да.

process.exit надо запускаться через cli, например, в enb-magic-platform.

Всё остальное, включая этот пакет должно просто возвращать ошибку.

}

if (opts.coverage.engines.length > 0) {
processCoverage(opts.coverage).done(resolvePromise);
processCoverage(opts.coverage)
.done(resolvePromise, resolvePromise);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если мы тут получим fail и внутри resolvePromise() произойдет resolve(), это нормально, что мы не увидем ошибки?

@blond
Copy link
Member Author

blond commented Jul 17, 2015

@unlok Исправил обработку fail. Но теперь возникает ошибка:

TypeError: Cannot read property 'length' of undefined
    at /Users/blond/projects/enb-bem-tmpl-specs/node_modules/istanbul/lib/object-utils.js:248:37
    at Array.forEach (native)
    at Object.mergeFileCoverage (/Users/blond/projects/enb-bem-tmpl-specs/node_modules/istanbul/lib/object-utils.js:244:31)
    at /Users/blond/projects/enb-bem-tmpl-specs/lib/unmap-coverage.js:77:42
    at /Users/blond/projects/enb-bem-tmpl-specs/node_modules/lodash/index.js:3073:15
    at baseForOwn (/Users/blond/projects/enb-bem-tmpl-specs/node_modules/lodash/index.js:2046:14)
    at /Users/blond/projects/enb-bem-tmpl-specs/node_modules/lodash/index.js:3043:18
    at Function.<anonymous> (/Users/blond/projects/enb-bem-tmpl-specs/node_modules/lodash/index.js:3346:13)
    at mergeCoverage (/Users/blond/projects/enb-bem-tmpl-specs/lib/unmap-coverage.js:75:7)
    at Array.reduce (native)

Очень похоже на gotwarlost/istanbul#402. Ошибка возникает, когда b: {}.

Если собирать примеры, то b: {} будет у файла examples/blocks/image/image.bh.js.

/сс @SevInf

@j0tunn
Copy link
Contributor

j0tunn commented Aug 1, 2015

нужно отрибейзить по master
Падение исправлено в #98

blond added a commit that referenced this pull request Aug 1, 2015
Fixed bug with impossible to exit
@blond blond merged commit 8d26011 into master Aug 1, 2015
@blond blond removed the review label Aug 1, 2015
@blond blond deleted the issue-88 branch August 1, 2015 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants