Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support native mocha reporters #90

Merged
merged 2 commits into from
Jun 22, 2015
Merged

Support native mocha reporters #90

merged 2 commits into from
Jun 22, 2015

Conversation

blond
Copy link
Member

@blond blond commented Jun 20, 2015

Resolved #38

Need use BEM_TMPL_SPECS_REPORTERS environment variable.

Run examples with dot reporter:

BEM_TMPL_SPECS_REPORTERS=dot enb -d examples/silly make tmpl-specs

2015-06-20 18 19 47

If reporter is not found program exit before build:

2015-06-20 18 24 07

@blond
Copy link
Member Author

blond commented Jun 20, 2015

/cc @tormozz48 @sipayRT @tavriaforever

@blond blond added review and removed in progress labels Jun 21, 2015
this._opts = opts;
this._mocha = new Mocha({
ui: 'bdd',
reporter: runReporters(opts.diffOpts),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diffOpts - что-то прогадали с названием. Почему не htmlDiffOpts? Название было бы длиннее, но было бы сразу понятно что это такое.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Возможно :)

@sipayRT
Copy link

sipayRT commented Jun 22, 2015

👍

blond added a commit that referenced this pull request Jun 22, 2015
Support native mocha reporters
@blond blond merged commit 1a8859e into master Jun 22, 2015
@blond blond removed the review label Jun 22, 2015
@blond blond deleted the issue-38 branch June 22, 2015 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants