Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly save HTML in case of test failure #85

Merged
merged 1 commit into from
May 27, 2015
Merged

Correctly save HTML in case of test failure #85

merged 1 commit into from
May 27, 2015

Conversation

SevInf
Copy link

@SevInf SevInf commented May 26, 2015

Assertion was performed before saving, so in case of test
failre HTML never was saved. Fixed by saving html before
call to assert.fail

@SevInf
Copy link
Author

SevInf commented May 26, 2015

@blond

if (htmlDiffer.isEqual(actual, expected)) {
assert.ok(actual);
done && done(null);
} else {
assert.fail(actual, expected, null, '\n');
<% if (saveHtml) {%>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему не записывать файл при успешном выполнении?

Assertion was performed before saving, so in case of test
failre HTML never was saved. Fixed by saving html before
call to assert.fail
@SevInf
Copy link
Author

SevInf commented May 27, 2015

@blond вернул сохранение в случае успеха.

blond added a commit that referenced this pull request May 27, 2015
Correctly save HTML in case of test failure
@blond blond merged commit 3bfae5d into master May 27, 2015
@blond blond removed the in progress label May 27, 2015
@blond blond deleted the fix/save branch May 27, 2015 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants