isAsync feature and a bunch of lang bugs #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qfox
force-pushed
the
feature/isAsync
branch
from
c699be8
to
3aa7b6d
Compare
|
@tadatuta @andrewblond Can you take a look? |
qfox
force-pushed
the
feature/isAsync
branch
3 times, most recently
from
d88ed71
to
92491a9
Compare
|
Thanks for this contribution! Looks good to me. I need to spend some time on manual testing before I can say anything on this Pull Request. |
|
|
||
| } else { // engine.isAsync %> | ||
| // async mode | ||
| engines['${ engine.name }']${ subreference }.apply(bemjson, function (errs, actual) { |
There was a problem hiding this comment.
Можно еще из references['${ it }']${ subreference } сделать ${ ref }, и из engine соотв.
qfox
force-pushed
the
feature/isAsync
branch
from
92491a9
to
9d15e71
Compare
| @@ -98,6 +96,7 @@ module.exports = require('enb/lib/build-flow').create() | |||
| var langTarget = target.replace('.js', '.' + lang + '.js'); | |||
| return { | |||
| name: lang, | |||
| isAsync: engine.options.isAsync, | |||
There was a problem hiding this comment.
engine.options contains options for tech, it's better to use engine.async instead of engine.options.isAsync
qfox
force-pushed
the
feature/isAsync
branch
3 times, most recently
from
31dbb31
to
781d94f
Compare
qfox
force-pushed
the
feature/isAsync
branch
from
781d94f
to
afa758a
Compare
| var name = what.name, | ||
| target = what.target, | ||
| exportName = what.exportName; | ||
| lazy && print('lazies[\'' + lazy + '\'] = function () {\n'); |
There was a problem hiding this comment.
@andrewblond I don't know how to do it more elegant. Any thoughts?
added 2 commits
February 13, 2015 14:02
- restored htmlBeautifier func-ty - reworked langs it render - added async flag to force calling .apply with cb on engine - added safer call of i18n - fixed lang bugs
qfox
force-pushed
the
feature/isAsync
branch
from
afa758a
to
0916336
Compare
|
Looks great. 👍 @zxqfox Thanks for tackling this! |
blond
pushed a commit
that referenced
this pull request
Feb 13, 2015
isAsync feature and a bunch of lang bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.