Support reporting coverage for tests #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| CoverageObject.prototype = { | ||
| constructor: CoverageObject, | ||
|
|
||
| addStatement: function (start, end, counter) { |
There was a problem hiding this comment.
вот эти три функции(addStatement, addFunction, addBranch) несколько похожи друг на друга. Нет желания подрефакторить и убрать дублирование?
There was a problem hiding this comment.
Мне кажется, что эта похожесть — совпадение
There was a problem hiding this comment.
Похожесть только видимая, на самом деле:
- source достается из разных локаций (
startдля стейтментов и функций,locations[0]для бранчей) - индексы берутся из разных переменных (
b,f,s) - метаданные записываются в разные объекты (
branchMap,functionMap,statementMap) - структура метаданных везде разная (для стейтмена – просто
startиend, для функции{name, loc: {start, end}}, для ветвлений{line, type, locations: [{start, end}]) - счетчики записываются в разные объекты
b,f,s.
|
@SevInf ping! |
SevInf
force-pushed
the
feature/coverage2
branch
from
42c6bdd
to
cb1af0b
Compare
|
@SevInf для опций логично ожидать значений по умолчанию как в
|
SevInf
force-pushed
the
feature/coverage2
branch
from
cb1af0b
to
3d11ce7
Compare
|
@andrewblond, поправил, нужно финальное ревью. |
SevInf
force-pushed
the
feature/coverage2
branch
2 times, most recently
from
640985c
to
e4b9700
Compare
|
@andrewblond исправил вчерашний баг |
If `coverage` options is set, template files will be instrumented before execution (can be enabled per-technology). If templates are built with source map, there is an option to show coverage for original files. There is also an option to filter out some sources from report. By default, all content of `node_modules` and `libs` will be omitted.
SevInf
force-pushed
the
feature/coverage2
branch
from
e4b9700
to
97508b4
Compare
|
@SevInf, всё супер! =) |
blond
pushed a commit
that referenced
this pull request
Nov 27, 2014
Support reporting coverage for tests
Closed
|
Вошло в версию |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
coverageoptions is set, template files will be instrumentedbefore execution (can be enabled per-technology). If templates are
built with source map, there is an option to show coverage for
original files.
There is also an option to filter out some sources from report. By
default, all content of
node_modulesandlibswill be omitted.@andrewblond @arikon @j0tunn