Improving performance and GC issues #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qfox
force-pushed
the
zxqfox.perf-rerequire
branch
from
d270b26
to
8af6e79
Compare
| var bemjson = references['${ it }']${ subreference }.bemjson, | ||
| expected = references['${ it }']${ subreference }.html;<% | ||
|
|
||
| if (!engine.async) { %> | ||
| // sync mode | ||
| var actual = engines['${ engine.name }']${ subreference }.apply(bemjson); | ||
| var actual = engine.apply(bemjson); |
There was a problem hiding this comment.
Let's apply this to async mode as well: https://github.com/enb/enb-bem-tmpl-specs/pull/125/files#diff-b3ae0a4158614ff6d4c87ca1707c1221R30
There was a problem hiding this comment.
So true, eagle eye!
Thank you.
qfox
force-pushed
the
zxqfox.perf-rerequire
branch
from
8af6e79
to
551c3d3
Compare
Rework a little where and how clearRequire-require combo works. Just it improved performance a lot. Also stopped usign this combo for references.
qfox
force-pushed
the
zxqfox.perf-rerequire
branch
from
551c3d3
to
dc9759a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We catching a lot of problems on using the current version of tmpl-specs because 6 templators on several hundreds of samples makes nodejs going oom.
Also it improves performance. So MERGE IT MERGE IT