Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mock-lang-js tech #100

Merged
merged 1 commit into from
Aug 4, 2015
Merged

Fixed mock-lang-js tech #100

merged 1 commit into from
Aug 4, 2015

Conversation

blond
Copy link
Member

@blond blond commented Aug 4, 2015

Resolved #94

* Used `enb-source-map` to concat files
* Supported [email protected] with BEM.I18N
@blond blond added the review label Aug 4, 2015
@blond blond changed the title Fixed mock-lang-js tech: Fixed mock-lang-js tech Aug 4, 2015
@blond
Copy link
Member Author

blond commented Aug 4, 2015

@scf2k Можешь убедиться, что с coverage всё ок? В примерах к этому пакету всё осталось так же.

.builder(function (sourceFilename) {
return vfs.read(sourceFilename, 'utf8')
.then(function (contents) {
var withSourceMaps = true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Используется в одном месте. Просто передать true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В одном месте, просто чтобы читалось лучше.

blond added a commit that referenced this pull request Aug 4, 2015
Fixed `mock-lang-js` tech
@blond blond merged commit 2c21718 into master Aug 4, 2015
@blond blond removed the review label Aug 4, 2015
@blond blond deleted the issue-94 branch August 4, 2015 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants