Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/* istanbul ignore next */ comments are ignored at build complex report #73

Closed
xoxulin opened this issue Mar 2, 2015 · 0 comments · Fixed by #75
Closed

/* istanbul ignore next */ comments are ignored at build complex report #73

xoxulin opened this issue Mar 2, 2015 · 0 comments · Fixed by #75
Milestone
0.11

Comments

@xoxulin
Copy link

xoxulin commented Mar 2, 2015

Here statement contains skip: true if this statement was pre-commented by /* istanbul ignore ... */. Also here and here.
@xoxulin xoxulin changed the title Istanbul ignoring comments are ignored at build complex report /* istanbul ignore next */ comments are ignored at build complex report Mar 2, 2015
@SevInf SevInf mentioned this issue Mar 3, 2015
Merged
SevInf pushed a commit that referenced this issue Mar 3, 2015
Don't skip istanbul's ignore flags
2d0ac35 
Istanbul has ability to ignore certain statements, functions or
branches. This information is lost when we are splitting built file
coverage into sources. This patch restores `skip` flags.

Fix #73
@blond blond closed this as completed in #75 Mar 4, 2015
@blond blond added this to the 0.11 milestone Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11
Development

Successfully merging a pull request may close this issue.

Don't skip istanbul's ignore flags enb/enb-bem-tmpl-specs
3 participants
@SevInf @xoxulin @blond