-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cache issue in levels-to-bemdecl tech #229
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `node.getLevelNamingScheme` and the `node.setLevelNamingScheme` methods will be removed in `[email protected]`.
Got rid of scheme builders
Redundant code of deps
Remove deprecated techs
Remove deprecated options
The `mock-fs` does not support `require` for Node.js 4. Because of this test failed with error: ``` Cannot find module 'path/to/file.js ```
Support Node.js 4
**Example of new format:** ``` { button__text: [ { entity: { block: ‘button’, elem: ‘text’ }, tech: ‘css’, path: ‘path/to/file.ext’, level: ‘path/to/level’ }, /* ... */ ], /* ... */ } ``` With this introspection format to easily get a list of files named entity. **What has been done?** * Use `bem-walk` to scan levels. * Use `bem-naming` to get id of BEM entity. * Add `BundleIntrospection` class to work with introspection of levels for one bundle. * Rewrite `levels` tech with `build-flow`. * Use promises with `node.buildState` to avoid scanning the same levels multiple times. * Don't read files for directories (example i18n), it should do `files` tech.
Now the `bem-walk` is used to scan.
Exactly the same benchmarks in `bem-walk` repository
Introspection Format
API moved to bottom of list
Remove 'docs/bem-project.md' file
Used the `files` field in `package.json`
Replaced *.bemhtml with *.bemhtml.js [issue 404]
Closed in favor of #255 |
Fixed in v2.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@blond