Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps tech: Support empty block-name.deps.js #151

Closed
tadatuta opened this issue May 18, 2015 · 1 comment
Closed

deps tech: Support empty block-name.deps.js #151

tadatuta opened this issue May 18, 2015 · 1 comment
Assignees
@tormozz48
Labels
bug prio:normal
Milestone
2.0

Comments

@tadatuta
Copy link
Member

Now block-name.deps.js with commented out content will fail with

TypeError: Cannot read property 'tech' of undefined
    at /Users/tadatuta/Sites/startrek-www/node_modules/islands-tools/node_modules/enb-bem-techs/lib/deps/deps-resolver.js:203:33

Expected: empty (or commented) files are just skipped.
@tadatuta tadatuta added the bug label May 18, 2015
@blond blond added this to the 1.0.5 milestone May 18, 2015
@blond blond modified the milestones: 1.0.5, 2.0 Jul 9, 2015
@tormozz48
Copy link
Contributor

@blond Кажется, что важная и полезная фича. Могу взяться

@tormozz48 tormozz48 self-assigned this Jul 10, 2015
tormozz48 added a commit that referenced this issue Jul 10, 2015
@tormozz48
#151 Fix issue which occur for empty deps.js. Support empty block-nam…
b56d07b 
…e.deps.js
@tormozz48 tormozz48 mentioned this issue Jul 10, 2015
Merged
tormozz48 added a commit that referenced this issue Jul 10, 2015
@tormozz48
#151 Fix codestyle issue
f234008
tormozz48 added a commit that referenced this issue Jul 10, 2015
@tormozz48
#151 Add two advanced tests for verify cases of deps.js file with com…
6043551 
…mented code
@blond blond added in progress and removed review labels Jul 13, 2015
tormozz48 added a commit that referenced this issue Jul 14, 2015
@tormozz48
#151 Add tests for missed or commented deps.js files for deps-old tec…
559f133 
…hnology. Remove exceed code from tests
tormozz48 added a commit that referenced this issue Jul 14, 2015
@tormozz48
#151 Fix issue which occur for empty deps.js. Support empty block-nam…
4b241df 
…e.deps.js
tormozz48 added a commit that referenced this issue Jul 14, 2015
@tormozz48
#151 Fix codestyle issue
04ecf7c
tormozz48 added a commit that referenced this issue Jul 14, 2015
@tormozz48
#151 Add two advanced tests for verify cases of deps.js file with com…
3e59567 
…mented code
tormozz48 added a commit that referenced this issue Jul 14, 2015
@tormozz48
#151 Add tests for missed or commented deps.js files for deps-old tec…
e42c488 
…hnology. Remove exceed code from tests
tormozz48 added a commit that referenced this issue Jul 14, 2015
@tormozz48
#151 Fix codestyle issues which occurs after rebasing on master branch
4099d93
@gela-d gela-d added review and removed in progress labels Jul 14, 2015
tormozz48 added a commit that referenced this issue Jul 14, 2015
@tormozz48
#151 Support empty block-name.deps.js
aa0db22
@blond blond removed the review label Jul 14, 2015
blond added a commit that referenced this issue Jul 14, 2015
@blond
Merge pull request #164 from enb-bem/issue-151
359d2b5 
#151 Support empty block-name.deps.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tormozz48 tormozz48

Labels
bug prio:normal
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
5 participants
@tadatuta @tormozz48 @gela-d @blond @levonet