Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-37902: fix windows-specific ilib issues with testing #121

Merged
merged 3 commits into from
Mar 8, 2018

Conversation

JayCanuck
Copy link
Member

@JayCanuck JayCanuck commented Mar 6, 2018

Requires enactjs/dev-utils#11

  • Use karma-webpack 2.0.6 specifically as that's the last build before they changed from a virtual /_karma_webpack_/ to one based on os.tmpdir() (fix: use os.tmpdir() to safely store _karma_webpack_ codymikol/karma-webpack#279) which seems to fail on Windows since the drive-letter causes URL issues.
  • Increase Mocha timeout to 30 seconds, since PhantomJS is slow and picky 🐢.
  • Set PhantomJS as the default browser since we were basically already treating it as such. Ideally will switch to headless-Chrome/Puppeteer in the near future.

Enact-DCO-1.0-Signed-off-by: Jason Robitaille [email protected]

Copy link
Contributor

@germboy germboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - and works even better! 👍

@ryanjduffy ryanjduffy merged commit ce09ca8 into develop Mar 8, 2018
@ryanjduffy ryanjduffy deleted the feature/PLAT-37902 branch March 8, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants