Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The plugin won't close Streams #4

Closed
sebasblancogonz opened this issue Nov 20, 2019 · 4 comments · Fixed by #6
Closed

The plugin won't close Streams #4

sebasblancogonz opened this issue Nov 20, 2019 · 4 comments · Fixed by #6
Assignees
@lukaslisowski @simonnagl
Labels
bug Something isn't working
Milestone
1.0.5

Comments

@sebasblancogonz
Copy link

Since it won't close Streams, it'll make impossible to delete the .7z file and it's parent folder.
@simonnagl
Copy link
Member

Hi @sebasblancogonz, thank you for reporting thins bug. You are totally right. We will fix this issue in our next release.

@simonnagl simonnagl added the bug Something isn't working label Nov 20, 2019
@simonnagl simonnagl added this to the 1.0.5 milestone Nov 20, 2019
@sebasblancogonz
Copy link
Author

Great! I could submit a PR if you like

@simonnagl
Copy link
Member

Contributions are welcome!

@sebasblancogonz sebasblancogonz mentioned this issue Nov 20, 2019
Closed
simonnagl added a commit that referenced this issue Nov 22, 2019
@simonnagl
Always close SevenZFile after extraction.
b9685ea 
Fixes #4
@simonnagl simonnagl mentioned this issue Nov 22, 2019
Merged
simonnagl added a commit that referenced this issue Nov 22, 2019
@simonnagl
Always close SevenZFile after extraction.
97e84a5 
Fixes #4
@simonnagl
Copy link
Member

I just published Version 1.0.5 of the plugin. I hope it fixes your issues. If not, please reopen this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukaslisowski lukaslisowski

@simonnagl simonnagl

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.5
Development

Successfully merging a pull request may close this issue.

Close SevenZInput emundo/7z-gradle-plugin
3 participants
@lukaslisowski @simonnagl @sebasblancogonz